Develop #533
Open
Develop #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanyaBratashchuk
suggested changes
Nov 15, 2024
|
https://anastasiiakorolko.github.io/react_phone-catalog/ All ESLint was passed |
volodymyr-soltys97
suggested changes
Nov 16, 2024
anastasiiavorobiova
suggested changes
Nov 16, 2024
anastasiiavorobiova
suggested changes
Nov 16, 2024
There was a problem hiding this comment.
Great work!
Consider moving to the first page and hiding unneeded pagination links
Consider following the design. It's hard to read the product name
The footer shouldn't be at the top
Also, consider adding a link to your GH repo in the footer
No need to show the price if the cart is empty
The back button leads to the 404 page on some pages
VitaliyBondarenko1982
suggested changes
Nov 16, 2024
|
I checked everything. |
SanyaBratashchuk
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://anastasiiakorolko.github.io/react_phone-catalog/api
An interactive phone catalog built with React. Includes features for searching, filtering, sorting, and viewing details about phones.
All EssLint test was passed